-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing provider config defaultTags #1393
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1393 +/- ##
==========================================
- Coverage 23.40% 23.39% -0.01%
==========================================
Files 25 25
Lines 4230 4244 +14
==========================================
+ Hits 990 993 +3
- Misses 3077 3088 +11
Partials 163 163 ☔ View full report in Codecov by Sentry. |
Make it align to what we parse in the provider - a string map, rather than an object with a "tags" property which is a string map.
ce483a2
to
564817d
Compare
So this looks good provided you do want to take a breaking change here. One reason to think twice, I checked with TF they also have this structure:
I'm not sure but I think it's because there is some code around called TagIgnoreConfig and so forth, and possibly there were some plans to make the defaultTags do more than just add tags in the TF Provider but also have some sort of "policy" impact on transforming existing tags. Perhaps that's why this was modeled as a struct so new fields could have been added later. But they never were. Perhaps in Pulumi the answer to this sort of thing is using transformations and it's never going to be needed anyway. |
- Allow the provider to parse both the old and new schemas for compatability.
1512b95
to
56a6362
Compare
- Switch to using an explicit provider to also ensure the schema is correct. - Fix module name.
Fix the provider to parse the format as defined by the schema.
Keep a fallback in place to allow it parsing the default tags as a simple map for backward compatibility.